Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TestSpawner_CreateJobDeleteJob #13390

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Update TestSpawner_CreateJobDeleteJob #13390

merged 4 commits into from
Jun 5, 2024

Conversation

reductionista
Copy link
Contributor

@reductionista reductionista commented Jun 1, 2024 •
edited
Loading

This is one step toward removing ocr2vrf from the codebase.

Replaces the example ocr2vrf job spec used in TestSpawner_CreateJobDeleteJob with an ocr2keeper job spec

While working on this, I noticed two minor issues with the cleanupEVM helper called by the OCR2 job delegate's OnDeleteJob callback.

  1. Only Keepers 2.0 jobs were unregistering their LogPoller filters. Keepers 2.1 jobs were registering filters but never unregistering them.
  2. Fix typo & formatting of log msg

@reductionista reductionista requested review from a team as code owners June 1, 2024 04:05
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 1, 2024

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

jmank88
jmank88 previously approved these changes Jun 1, 2024
View reviewed changes
@reductionista reductionista force-pushed the BCF-3246-update-spawner-test branch from 20beea1 to 022f872 Compare June 3, 2024 15:12
@reductionista reductionista added this pull request to the merge queue Jun 5, 2024
Merged via the queue into develop with commit 59c74da Jun 5, 2024
105 of 106 checks passed
@reductionista reductionista deleted the BCF-3246-update-spawner-test branch June 5, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krehermann krehermann krehermann approved these changes

@jmank88 jmank88 jmank88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reductionista @jmank88 @krehermann